CI(Python): dont use --sdist in maturin build for CI#2166
Merged
blackmwk merged 1 commit intoapache:mainfrom Feb 24, 2026
Merged
CI(Python): dont use --sdist in maturin build for CI#2166blackmwk merged 1 commit intoapache:mainfrom
blackmwk merged 1 commit intoapache:mainfrom
Conversation
mbutrovich
approved these changes
Feb 23, 2026
Collaborator
mbutrovich
left a comment
mbutrovich
left a comment
There was a problem hiding this comment.
Thanks for the fix @kevinjqliu!
Contributor
Author
|
maturin maintainers already fixed it 🚀 PyO3/maturin#3031 we should still proceed with this PR and remove the unnecessary |
blackmwk
approved these changes
Feb 24, 2026
Contributor
blackmwk
left a comment
blackmwk
left a comment
There was a problem hiding this comment.
Thanks @kevinjqliu for this fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
This PR updates Python bindings CI to avoid
--sdistin the test build step due tomaturinregression for 1.12.3+ tracked in PyO3/maturin#3030. We dont pin maturin in CI, so CI installs the latest version.--sdistis not needed here, removing it also aligns with othermaturinusage in CISee https://github.com/search?q=repo%3Aapache%2Ficeberg-rust+%22command%3A+build%22&type=code
Are these changes tested?