907: Improve META-INF/MANIFEST.MF #916
Closed
rohitYaduvanshi wants to merge 2 commits intoapache:mainfrom
Closed
Conversation
bchapuis
reviewed
Jan 13, 2025
pom.xml
Outdated
| <Build-Jdk>${java.version}</Build-Jdk> | ||
| <Build-Version>${project.version}</Build-Version> | ||
| <Build-Jdk>${java.version}</Build-Jdk> | ||
| <Specification-Title>Apache Baremaps CSV (incubating)</Specification-Title> |
Member
There was a problem hiding this comment.
@rohitYaduvanshi Thanks for this PR. I guess we should probably add a <name> tag in all sub modules (e.g baremaps-csv/pom.xml) and use it to generate the Specification-Title dynamically. From what I understand, with the current solution, all the generated jars will have the same specification title.
<name>baremaps-csv</name>
...
<Specification-Title>${project.name}</Specification-Title>
|
Member
|
@rohitYaduvanshi I merged your commits in #917 as the plan is to start a release process later this week. Thanks a lot for the modification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the content of the
META-INF/MANIFEST.MFfile by adding more detailed and descriptive metadata entries, as requested in issue #907.The following changes were made:
Specification-Titlewith a more descriptive value.Specification-VendortoApache Software Foundation.Implementation-Vendorwith the correct organization name.Changes
maven-jar-pluginconfiguration inpom.xmlto include additional manifest entries.Issue Reference
Resolves #907