feature：support db2 in AT mode by GoodBoyCoder · Pull Request #4096 · apache/incubator-seata

GoodBoyCoder · 2021-10-25T11:40:26Z

I have registered the PR changes.

Ⅰ. Describe what this PR did

support DB2 DataBase

Ⅱ. Does this pull request fix one issue?

fixes #3744

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Identity column of type generated always as identity is not supported. This type of Identity value can only be generated by the system, which will cause Execption when performing Delete rollback compensation. If necessary, it is recommended to use BY DEFAULT
"Insert into table_name (...) values (?, ?, ?, ?);" This type of SQL with ";" added after it, if you add a sign that needs to return the auto-incremented primary key value (such as Statement.RETURN_GENERATED_KEYS, primary key column), it will be abnormal when executed, it is normal not to add ";"

…utor

…velop

lgtm-com · 2021-10-25T12:10:44Z

This pull request introduces 2 alerts when merging aa477ef into 0c2ae32 - view on LGTM.com

new alerts:

1 for Potential database resource leak
1 for Boxed variable is never null

lgtm-com · 2021-11-11T07:53:50Z

This pull request introduces 2 alerts when merging 2ba2519 into 6f877fa - view on LGTM.com

new alerts:

1 for Potential database resource leak
1 for Boxed variable is never null

lgtm-com · 2021-11-13T08:14:45Z

This pull request introduces 2 alerts when merging 2ba2519 into f67644a - view on LGTM.com

new alerts:

1 for Potential database resource leak
1 for Boxed variable is never null

lgtm-com · 2021-11-13T09:21:46Z

This pull request introduces 2 alerts when merging 979806e into 6f877fa - view on LGTM.com

new alerts:

1 for Potential database resource leak
1 for Boxed variable is never null

# Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/AbstractStatementProxy.java # rm-datasource/src/main/java/io/seata/rm/datasource/DataSourceProxy.java # rm-datasource/src/test/java/io/seata/rm/datasource/DataSourceProxyTest.java

lgtm-com · 2022-03-15T16:47:02Z

This pull request introduces 2 alerts when merging 84e15eb into 4c88984 - view on LGTM.com

new alerts:

1 for Potential database resource leak
1 for Boxed variable is never null

funky-eyes

LGTM

lgtm-com · 2022-04-21T14:41:48Z

This pull request introduces 2 alerts when merging 936423f into 8cefdbb - view on LGTM.com

new alerts:

1 for Potential database resource leak
1 for Boxed variable is never null

CLAassistant · 2022-12-12T13:18:31Z

All committers have signed the CLA.

CLAassistant · 2022-12-12T13:18:33Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 4 committers have signed the CLA.

❌ a364176773
❌ qingjiusanliangsan
❌ GoodBoyCoder
❌ wangliang181230
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

# Conflicts: # rm-datasource/src/test/java/io/seata/rm/datasource/DataSourceProxyTest.java

# Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/DataSourceProxy.java # rm-datasource/src/main/resources/META-INF/services/io.seata.rm.datasource.exec.InsertExecutor # rm-datasource/src/main/resources/META-INF/services/io.seata.rm.datasource.sql.struct.TableMetaCache # rm-datasource/src/main/resources/META-INF/services/io.seata.rm.datasource.undo.UndoExecutorHolder # rm-datasource/src/main/resources/META-INF/services/io.seata.rm.datasource.undo.UndoLogManager # rm-datasource/src/main/resources/META-INF/services/io.seata.sqlparser.KeywordChecker # rm-datasource/src/test/java/io/seata/rm/datasource/DataSourceProxyTest.java # sqlparser/seata-sqlparser-druid/src/main/resources/META-INF/services/io.seata.sqlparser.druid.SQLOperateRecognizerHolder

# Conflicts: # rm-datasource/src/main/java/org/apache/seata/rm/datasource/sql/struct/cache/DB2TableMetaCache.java # rm-datasource/src/main/resources/META-INF/services/io.seata.rm.datasource.exec.InsertExecutor # rm-datasource/src/main/resources/META-INF/services/io.seata.rm.datasource.undo.UndoExecutorHolder # rm-datasource/src/main/resources/META-INF/services/io.seata.rm.datasource.undo.UndoLogManager # rm-datasource/src/main/resources/META-INF/services/io.seata.sqlparser.EscapeHandler # rm-datasource/src/main/resources/META-INF/services/io.seata.sqlparser.struct.TableMetaCache # rm-datasource/src/test/java/org/apache/seata/rm/datasource/exec/DB2InsertExecutorTest.java # rm-datasource/src/test/java/org/apache/seata/rm/datasource/sql/struct/cache/DB2TableMetaCacheTest.java # sqlparser/seata-sqlparser-druid/src/main/resources/META-INF/services/io.seata.sqlparser.druid.SQLOperateRecognizerHolder

qingjiusanliangsan and others added 28 commits August 22, 2021 17:25

add db2 sql recognier(seata#3744)

41a320d

Merge branch 'develop' into develop

e96afef

add db2 sql keyword checker，undo executor，table meta cache，InsertExec…

bbba576

…utor

Merge branch 'develop' of github.com:qingjiusanliangsan/seata into de…

aa484ad

…velop

Merge branch 'develop' into develop

bf71c42

Merge branch 'develop' into develop

10f96c6

complete undolog

1c680f3

Merge branch 'develop' of github.com:qingjiusanliangsan/seata into de…

ed5ebf4

…velop

refactor:check code style

93c678b

Merge branch 'develop' into feature_support_db2

d1abcba

refactor:check code style

b5fe33b

feature:add db2 undo_log sql script

eefa95a

bugfix:add spi load level for db2 insert executor

b28f2c8

test:add test cases for DB2InsertExecutor

69e08ab

bugfix:fix the undoExecutor error

3a7145d

bugfix:fix the error when get tableMetaCache for db2

850f656

bugfix:fix some bugs

453a004

bugfix:fix some bugs

e163f50

bugfix:fix getGeneratedKeys error

419da0e

bugfix:fix sql error

cfffdc1

refactor:check code style

978b509

bugfix:fix can not get specific columns when using table name in sql

2521c9f

bugfix:change undo_log sql

c45ade3

test:add test cases

6f192f9

test:add test cases

4c32df8

refactor:user "+" to replace String.format()

1f0408c

refactor:check code style

9bda01f

Merge branch 'develop' into feature_support_db2

aa477ef

funky-eyes added this to the 2.0.0 milestone Oct 25, 2021

funky-eyes mentioned this pull request Nov 12, 2021

feature：support h2 in AT mode #4133

Closed

funky-eyes changed the base branch from develop to 2.0.0 November 13, 2021 07:44

refactor: check code style

979806e

GoodBoyCoder added 2 commits March 15, 2022 23:36

merge 2.0

84e15eb

funky-eyes changed the base branch from 2.0.0 to develop April 21, 2022 14:09

Merge branch 'develop' into feature_support_db2

936423f

funky-eyes previously approved these changes Apr 21, 2022

View reviewed changes

Merge remote-tracking branch 'upstream/2.0.0' into feature_support_db2

41e91ef

# Conflicts: # rm-datasource/src/test/java/io/seata/rm/datasource/DataSourceProxyTest.java

GoodBoyCoder changed the base branch from develop to 2.0.0 February 17, 2023 07:54

funky-eyes modified the milestones: 2.0.0, 2.x Backlog Nov 4, 2023

slievrly changed the base branch from 2.0.0 to 2.x November 20, 2023 13:17

GoodBoyCoder added 2 commits November 28, 2023 23:52

fix:solve merge conflict

51c1daf

GoodBoyCoder dismissed funky-eyes’s stale review via 51c1daf December 23, 2023 07:27

GoodBoyCoder added 7 commits December 23, 2023 18:29

Merge branch '2.x' into feature_support_db2

5a0bac2

test:solve failed test

f1253dc

Merge branch '2.x' into feature_support_db2

3ec458a

test:solve failed test

b089021

test:solve license check failed

d7ebcd4

refactor:solve check style failed

dc48c02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feature：support db2 in AT mode#4096

feature：support db2 in AT mode#4096
GoodBoyCoder wants to merge 50 commits into
apache:2.xfrom
GoodBoyCoder:feature_support_db2

GoodBoyCoder commented Oct 25, 2021 •

edited

Loading

Uh oh!

lgtm-com Bot commented Oct 25, 2021

Uh oh!

lgtm-com Bot commented Nov 11, 2021

Uh oh!

lgtm-com Bot commented Nov 13, 2021

Uh oh!

lgtm-com Bot commented Nov 13, 2021

Uh oh!

lgtm-com Bot commented Mar 15, 2022

Uh oh!

funky-eyes left a comment

Uh oh!

lgtm-com Bot commented Apr 21, 2022

Uh oh!

CLAassistant commented Dec 12, 2022 •

edited

Loading

Uh oh!

CLAassistant commented Dec 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

GoodBoyCoder commented Oct 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Uh oh!

lgtm-com Bot commented Oct 25, 2021

Uh oh!

lgtm-com Bot commented Nov 11, 2021

Uh oh!

lgtm-com Bot commented Nov 13, 2021

Uh oh!

lgtm-com Bot commented Nov 13, 2021

Uh oh!

lgtm-com Bot commented Mar 15, 2022

Uh oh!

funky-eyes left a comment

Choose a reason for hiding this comment

Uh oh!

lgtm-com Bot commented Apr 21, 2022

Uh oh!

CLAassistant commented Dec 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented Dec 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

GoodBoyCoder commented Oct 25, 2021 •

edited

Loading

CLAassistant commented Dec 12, 2022 •

edited

Loading