KAFKA-20159: Group configuration for share.delivery.count.limit#21491
Open
TaiJuWu wants to merge 8 commits intoapache:trunkfrom
Open
KAFKA-20159: Group configuration for share.delivery.count.limit#21491TaiJuWu wants to merge 8 commits intoapache:trunkfrom
TaiJuWu wants to merge 8 commits intoapache:trunkfrom
Conversation
github-actions
bot
added
triage
AndrewJSchofield
requested changes
Feb 17, 2026
Member
AndrewJSchofield
left a comment
AndrewJSchofield
left a comment
There was a problem hiding this comment.
Thanks for the PR. Just a couple of initial comments at this stage. I'll take a deeper look later.
| ShareGroupConfig.SHARE_GROUP_MIN_DELIVERY_COUNT_LIMIT_CONFIG); | ||
| } | ||
| if (shareDeliveryCountLimit > shareGroupConfig.shareGroupMaxDeliveryCountLimit()) { | ||
| throw new InvalidConfigurationException(SHARE_DELIVERY_COUNT_LIMIT_CONFIG + " must be greater than or equal to " + |
|
|
||
| public static final String SHARE_GROUP_MIN_RECORD_LOCK_DURATION_MS_CONFIG = "group.share.min.record.lock.duration.ms"; | ||
| public static final int SHARE_GROUP_MIN_RECORD_LOCK_DURATION_MS_DEFAULT = 15000; | ||
| public static final String SHARE_GROUP_MIN_RECORD_LOCK_DURATION_MS_DOC = "The record acquisition lock minimum duration in milliseconds for share groups."; |
Member
There was a problem hiding this comment.
I like the "value of a group configuration for" language. Could you please apply it for SHARE_GROUP_MIN_RECORD_LOCK_DURATION_MS_DOC and SHARE_GROUP_MAX_RECORD_LOCK_DURATION_MS_DOC?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
share.delivery.count.limitbecome dynamic config, we can changethe value at run time and set to specific group.