[QDP] DLPack Tensor unsafe Cleanup Refactoring#1011
Open
0lai0 wants to merge 1 commit intoapache:mainfrom
Open
[QDP] DLPack Tensor unsafe Cleanup Refactoring#10110lai0 wants to merge 1 commit intoapache:mainfrom
0lai0 wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
|
@0lai0 thanks for the patch! |
Contributor
Author
|
Sure, Thanks @rich7420 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of PR
This PR refactors DLPack tensor cleanup in qdp-core examples by introducing a shared helper (free_dlpack_tensor) in the DLPack module and updating examples to use it. This reduces duplicated unsafe code, adds defensive checks (null pointer / missing deleter), and improves error reporting when cleanup fails.
Related Issues or PRs
Related to #1009
Changes Made
Breaking Changes
Checklist