HDDS-15100. Add an OM config to toggle Ozone snapshot rename feature#10156
Draft
smengcl wants to merge 1 commit intoapache:masterfrom
Draft
HDDS-15100. Add an OM config to toggle Ozone snapshot rename feature#10156smengcl wants to merge 1 commit intoapache:masterfrom
smengcl wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
priyeshkaratha
left a comment
priyeshkaratha
left a comment
There was a problem hiding this comment.
Thanks @smengcl for the patch. Changes overall LGTM. There is an issue with testcase, please check the inline comment.
| OMException omException = assertThrows(OMException.class, | ||
| () -> doPreExecute(omRequest)); | ||
| assertEquals(FEATURE_NOT_ENABLED, omException.getResult()); | ||
| assertEquals("Ozone snapshot rename feature is not allowed per Ozone Manager server config", |
Contributor
There was a problem hiding this comment.
exception message mismatch. OMSnapshotRenameRequest throws the new FEATURE_NOT_ENABLED exception with a trailing period, but the new tests assert the message without it.
jojochuang
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
So far Ozone snapshot rename feature is buggy (see HDDS-11384) and we would like to have a config to disable this feature on Ozone Manager so it wouldn't be misused. AFAIK snapshot rename requires snapshot to fully transition to id-based to be truly safe to do.
For now, we should at least put it behind a config and disable that by default.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15100
How was this patch tested?