Skip to content

[core] Add JSON serialization support for Predicate and Transform #6993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
plusplusjiajia wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[core] Add JSON serialization support for Predicate and Transform #6993

plusplusjiajia wants to merge 5 commits into from

Conversation

@plusplusjiajia
Copy link
Member

@plusplusjiajia plusplusjiajia commented Jan 9, 2026

Purpose

Add Predicate and Transform json serialization utils

@JingsongLi
Copy link
Contributor

JingsongLi commented Jan 9, 2026

If possible, we'd better encapsulate the JSON serialization into specific classes, as this is the most effective way to avoid omissions.

@plusplusjiajia
Copy link
Member Author

plusplusjiajia commented Jan 9, 2026

If possible, we'd better encapsulate the JSON serialization into specific classes, as this is the most effective way to avoid omissions.

Excellent suggestion!

@plusplusjiajia plusplusjiajia changed the title [core]Add JSON serialization support for Predicate and Transform [core] Add JSON serialization support for Predicate and Transform Jan 10, 2026
@plusplusjiajia plusplusjiajia force-pushed the predicate-parse branch 5 times, most recently from 5d8a1fe to c9895bf Compare January 10, 2026 11:25
@plusplusjiajia
Copy link
Member Author

plusplusjiajia commented Jan 12, 2026

e'd better encapsulate the JSON serialization into specific classes
Thanks for your advise! I've made the changes according to your advise. Please review it when you have a chance.

JingsongLi
JingsongLi reviewed Jan 12, 2026
View reviewed changes
paimon-common/src/test/java/org/apache/paimon/predicate/PredicateJsonSerdeTest.java

private static Predicate roundTrip(Predicate predicate) {
String json = JsonSerdeUtil.toFlatJson(predicate);
return JsonSerdeUtil.fromJson(json, Predicate.class);
Copy link
Contributor

@JingsongLi JingsongLi Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have JSON expected result in the tests? This is a standard. We need to solidify serialization-related issues in the test at least.

Copy link
Contributor

@JingsongLi JingsongLi Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like DataTypeJsonParserTest.

Copy link
Member Author

@plusplusjiajia plusplusjiajia Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataTypeJsonParserTest

Thansk for you review. It's really a useful suggestion, I've updated the test.

JingsongLi
JingsongLi reviewed Jan 12, 2026
View reviewed changes
Copy link
Contributor

@JingsongLi JingsongLi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only two types: leaf and compound, TransformPredicate should be leaf type too.

  1. type leaf: transform, function and literals.
  2. type compound: function and children.

@JingsongLi
Copy link
Contributor

JingsongLi commented Jan 12, 2026

I try to unify them in #7015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JingsongLi JingsongLi JingsongLi left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@plusplusjiajia @JingsongLi