[BugFix] Fix field spec sort order #17467
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hongkun Xu <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17467 +/- ##
============================================
- Coverage 63.28% 63.26% -0.03%
Complexity 1476 1476
============================================
Files 3162 3162
Lines 188701 188701
Branches 28877 28877
============================================
- Hits 119425 119378 -47
- Misses 60017 60064 +47
Partials 9259 9259
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a logical bug in SegmentProcessorUtils where field specs were being sorted after being added to the final list, making the sort ineffective. The fix reorders the operations to sort each collection before adding it to the output list.
Key changes:
- Moved the sorting of
nonMetricFieldSpecsto occur before adding them tofieldSpecs - Moved the sorting of
metricFieldSpecsto occur before adding them tofieldSpecs
xiangfu0
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SegmentProcessorUtils, fields are classified and sorted when collecting all FieldSpecs.
However, there is a logical issue in the current implementation: although fields are added in the intended order, the sorting of nonMetricFieldSpecs happens after they are added to the final list, so the sort has no effect.
While this does not currently impact downstream behavior, the logic is incorrect and potentially misleading. This PR fixes the ordering to ensure the sorting is applied as intended.
Hi @Jackie-Jiang @xiangfu0 , please help review this PR when you are free.