Add browser shim for node:events module#9141
Open
alxndrsn wants to merge 5 commits intoapache:masterfrom
Open
Conversation
Contributor
Author
|
PR has been updated to handle |
node:events module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
import 'pouchdb-events'===import 'node:events'?This seems to be a common issue:
pouchdb-utilsdepends oneventsnpm package for the browser build, but does not declare it as a dependency. #8985I think it was introduced by 404346b, which upgrade from webpack 1 to webpack 5. From the webpack docs:
Alternatively, it may come from rollup.
Hopefully:
Closes #8968
Closes #8985
Closes #8989
Closes #9072
Closes #9078