-
Notifications
You must be signed in to change notification settings - Fork 29.1k
[SPARK-54759][SQL] SQL scripting Cursor support #53530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+3,799
−103
Closed
Changes from all commits
Commits
Show all changes
88 commits
Select commit
Hold shift + click to select a range
bdd15a9
Add cursor support to Spark SQL Scripting
srielau c28dd8f
Initial implementation
srielau eab7cd3
[SPARK-54759][SQL][WIP] Cursor support
srielau b64942e
Complete MVP fucntion.
srielau 9678674
Parameterized cursor support
srielau 8144b3d
Paramneterized cursor support
srielau 87874ef
Fix error messages
srielau 701f070
Fix keywords
srielau e7502e6
Fix more bugs
srielau bdfda8c
more fixes
srielau ca980ef
add tests for session variables
srielau 8368ed6
more fixes
srielau 8d782d6
proper NOT FOUND handler
srielau 81c8eb4
Merge branch 'master' into cursors
srielau ea28537
more tests
srielau cc8419c
Fix parameter marker bind in
srielau 7d5633e
Update sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plan…
srielau 69d76df
Address review comments and add config.
srielau f5f4b77
Fix identifier processing for cursors
srielau 883492f
Fix errro message order, pass multipart names, add case isnensitivity…
srielau 07530cf
Init commit
miland-db 376b8ee
Add isInCondition override in WhileStatementExec
miland-db 6006876
Merge branch 'master' into cursors
srielau 23070e7
[SPARK-XXXXX][SQL] Address cursor PR review comments
srielau f519917
[SPARK-XXXXX][SQL][WIP] Refactor cursor commands to use CursorReferen…
srielau f71d1e5
[SPARK-XXXXX][SQL] Refactor cursor commands to use CursorReference ex…
srielau bdf3bb7
[SPARK-XXXXX][SQL] Refactor cursor lifecycle management with explicit…
srielau b501120
[SPARK-XXXXX][SQL] Code quality improvements for cursor implementation
srielau 80965e4
[SPARK-XXXXX][SQL] Add invariant assertion to OpenCursor logical plan
srielau 52d07bc
[SPARK-XXXXX][SQL] Fix cursor state lookup to respect scope qualifica…
srielau 9e9f47f
[SPARK-55005][SQL] Merge PR#53759: Fix CONTINUE HANDLER to continue l…
srielau d8fe820
Merge branch 'master' into cursors
srielau d67f761
[SPARK-XXXXX][SQL] Change CursorReference.scopePath from Seq[String] …
srielau c951aa0
[SPARK-XXXXX][SQL] Add utility method to get scripting context for cu…
srielau 061ffff
[SPARK-XXXXX][SQL] Move cursor definition lookup to analysis time
srielau 512490c
[SPARK-XXXXX][SQL] Code review: Improve comments and documentation
srielau 11a06de
[SPARK-XXXXX][SQL] Add comprehensive tests for NO DATA / NOT FOUND ha…
srielau f910215
[SPARK-XXXXX][SQL] Regenerate cursors.sql golden file to fix whitespace
srielau 70a81cb
Fix goldenfiles
srielau e7b1185
[SPARK-XXXXX][SQL] Move CursorDefinition to CursorReference.scala and…
srielau da83661
[SPARK-XXXXX][SQL] Update comments to reflect delayed query parsing
srielau b3110c3
[SPARK-XXXXX][SQL] Refactor completion condition check to avoid empty…
srielau 3b1dccf
[SPARK-XXXXX][SQL] Remove dead code: setReturnCurrentWithoutAdvancing
srielau 7be6f7b
[SPARK-XXXXX][SQL] Move CursorState to separate file
srielau 383071e
[SPARK-XXXXX][SQL] Remove redundant resolved check in ResolveCursors
srielau 9749ca4
[SPARK-XXXXX][SQL] Validate cursor reference qualifiers
srielau cfe8126
[SPARK-XXXXX][SQL] Normalize scope label for case-insensitive cursor …
srielau fe7a21a
[SPARK-XXXXX][SQL] Validate cursor qualifier at parse time
srielau cf4a340
[SPARK-XXXXX][SQL] Replace reflection with extension API for cursor l…
srielau e647a68
[SPARK-XXXXX][SQL] Fix style issues in ResolveCursors
srielau dd2de65
[SPARK-XXXXX][SQL] Use toSQLId for cursor name in error message
srielau a648b1c
[SPARK-XXXXX][SQL] Format CloseCursor case class on single line
srielau 54afdf4
[SPARK-XXXXX][SQL] Add ResolveCursors to RuleIdCollection
srielau c057c0d
[SPARK-XXXXX][SQL] Import CursorReference instead of using fully qual…
srielau 47b6e55
[SPARK-XXXXX][SQL] Add tests for cursor access in CONTINUE handlers
srielau fbb587e
[SPARK-XXXXX][SQL] Fix cursor access across execution frames
srielau b0e31f9
[SPARK-XXXXX][SQL] Add tests for variable and cursor access in handlers
srielau dad9930
[SPARK-XXXXX][SQL] Fix FETCH variable resolution regression
srielau 8f61f3c
[SPARK-XXXXX][SQL] Address cursor PR review comments from cloud-fan
srielau a5515ed
[SPARK-XXXXX][SQL] Fix cursor bugs: case-insensitive labels, statemen…
srielau 0b85d6e
Revert "[SPARK-XXXXX][SQL] Remove dead code: setReturnCurrentWithoutA…
srielau 3a272c9
[SPARK-XXXXX][SQL] Restore returnCurrentWithoutAdvancing logic for RE…
srielau bc4d002
[SPARK-XXXXX][SQL] Fix cursor reopen after CLOSE + review cursors.sql…
srielau 273d106
[SPARK-XXXXX][SQL] Apply scalafmt formatting to QueryParsingErrors
srielau 59d5bba
[SPARK-XXXXX][SQL] Fix cursor shadowing in handlers
srielau 581a874
Minor cleanup
srielau edacf57
Update cursors.sql.out golden file with toSQLId() backticks
srielau 0755379
Address davidm-db review comments: Fix FETCH grammar and simplify Res…
srielau fa0fb53
Address davidm-db review: Extract duplicate resolution logic in Resol…
srielau 9c7da87
Address davidm-db review: Move cursor statements to statement rule fo…
srielau 85cb7cb
[SPARK-XXXXX][SQL] Create Scala test suite for cursors (16/86 tests, …
srielau c9ebf5a
[SPARK-XXXXX][SQL] Fix Tests 27-31: Use DECLARE for session variables…
srielau 0a82b25
[SPARK-XXXXX][SQL] Regenerate golden files after Tests 27-31 structur…
srielau ff87bcf
[SPARK-XXXXX][SQL] Complete comprehensive review of cursors.sql.out g…
srielau 1f8b342
debugging, reorg test suite, unify FETCH INTO with SET
srielau 4f09d53
Add new svcala suite
srielau b8acbc0
Merge branch 'master' into cursors
srielau b8e4f9c
remove sql script tests
srielau 5245576
More review comments
srielau b441e47
Fix cursor resolution across frames
srielau 2e5aa99
Refactor to share traversal logic for frame resolution
srielau f9d447a
Merge branch 'master' into cursors
srielau 5a0a1ea
Merge branch 'master' into cursors
srielau ba277f5
Backout bad continue handler foix
srielau 13aa89c
Danko's fixes to continue handler
srielau fea234d
Merge branch 'master' into cursors
srielau 62dfa5d
Update sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScri…
srielau 9749cfc
Update sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScri…
srielau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.