Implement field extensions

[martinbonnin]

See graphql/graphql-spec#1162

[apollo-librarian]

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 80f2fcf3ef30d0d7d99b89e4
Build Logs: View logs

[martinbonnin]

One thing to note is that I removed the possibility to change the field nullability:

type Query {
  foo: Int
}

# this is not working anymore
extend type Query {
  foo: Int! # Cannot change the type of a field
}

[martinbonnin]

Breaking change because SchemaValidationOptions was in an internal package. It was @ApolloExperimental so I'm hoping it's not too used.

[BoD]

This doesn't include the field extensions part?

[martinbonnin]

This doesn't include the field extensions part?

Can you ellaborate a bit what's missing?

[BoD]

This doesn't include the field extensions part?

Can you ellaborate a bit what's missing?

Should this implement the extend field syntax? Or it does and I'm confused?

[martinbonnin]

Ah yes, this was discussed in the December working group and there were concerns about different lexers, etc... So the recommendation was to use the existing syntax for simplicity.

This is what @egoodwinx made in the graphql-js PR

Adding a directive is done like so:

      type Query {
        random: Int
      }      
      extend type Query {
        random: Int @deprecated
      }

I don't have a strong opinion there but not using schema coordinates, sure simplifies things

[BoD]

So the recommendation was to use the existing syntax for simplicity.

Thanks a lot for the link! I was there but missed it 😅.

Yeah I actually like that it's a smaller change 👍

[BoD]

👍