This repository was archived by the owner on Feb 26, 2026. It is now read-only.
Merged
Conversation
ValJed
commented
Oct 15, 2025
| // Try hard to come up with a title, as without a slug we'll get an error | ||
| // at insert time | ||
| user.title = profile.displayName || profile.username || user.email || ''; | ||
| user.title = profile.displayName || profile.username || email || ''; |
Contributor
Author
There was a problem hiding this comment.
uses non normlized email for title.
ValJed
commented
Oct 15, 2025
| return { email }; | ||
| return { | ||
| email: self.apos.login.normalizeLoginName(email) | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
normalize in criteria to retrieve the user based on apps user info.
boutell
approved these changes
Oct 16, 2025
Member
boutell
left a comment
boutell
left a comment
There was a problem hiding this comment.
Yeah I think this makes sense, if you have set the system to case insensitive and you use a case-sensitive identity provider and that leads to a conflict, then you'll get an error, and that's a GOOD thing (it points out a real conflict that has to be addressed by the developer)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See ticket and core PR
Which could be frustrating and hard to understand for users.