CLI: stop and kill should error on not found containers#878
Open
dcantah wants to merge 1 commit intoapple:mainfrom
Open
CLI: stop and kill should error on not found containers#878dcantah wants to merge 1 commit intoapple:mainfrom
dcantah wants to merge 1 commit intoapple:mainfrom
Conversation
We should print a clear error message to stderr on if a container can't be found, as well as exiting with a 1 exit code.
dcantah
force-pushed
the
change-stop-and-kill-behavior
branch
from
cd90009 to
ace9702
Compare
jglogan
requested changes
Nov 14, 2025
| for id in containerIds { | ||
| if let container = containerMap[id] { | ||
| containers.append(container) | ||
| } else { |
Contributor
There was a problem hiding this comment.
do we need an error for trying to signal a non-running container here?
| @Argument(help: "Container IDs") | ||
| var containerIds: [String] = [] | ||
|
|
||
| struct KillError: Error { |
Contributor
There was a problem hiding this comment.
Wondering if this could be instead be moved into ContainerizationClient as public struct PartialSuccessError: Error?
| let allContainers = try await ClientContainer.list() | ||
| let containerMap = Dictionary(uniqueKeysWithValues: allContainers.map { ($0.id, $0) }) | ||
|
|
||
| for id in containerIds { |
Contributor
There was a problem hiding this comment.
Run state checks aren't wanted/needed here?
Member
Author
There was a problem hiding this comment.
The daemon returns an error if it's not running
| } | ||
|
|
||
| for (_, err) in error.failed { | ||
| allErrors.append("Error from APIServer: \(err)") |
| } | ||
|
|
||
| for (_, err) in error.failed { | ||
| allErrors.append("Error from APIServer: \(err.localizedDescription)") |
| import ContainerizationOS | ||
| import Foundation | ||
|
|
||
| struct StandardError: TextOutputStream, Sendable { |
Contributor
There was a problem hiding this comment.
This was referenced Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should print a clear error message to stderr on if a container can't be found, as well as exiting with a 1 exit code.
Type of Change