Replace protobuf/abseil submodules with vendored sources#2021
Open
kateinoigakukun wants to merge 3 commits intoapple:mainfrom
Open
Replace protobuf/abseil submodules with vendored sources#2021kateinoigakukun wants to merge 3 commits intoapple:mainfrom
kateinoigakukun wants to merge 3 commits intoapple:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2000.
SwiftPM recursively checks out git submodules during package resolution. The protobuf and abseil submodules are large C++ repositories, but every consumer has to pay the cost of fetching them for every checkout because SwiftPM cannot cache submodules as their bare repositories.
This PR replace protobuf/abseil submodules with vendored sources.
Commits
Reviewers can focus on the first commit; commits 2 and 3 are mechanical.
Alternative Considered
git subtree was also considered but ruled out: it does not support selective path filtering across multiple directories (we only need a subset of files from each repo).