Preview post-processing stage changes in appleseed.studio - #2885
Draft
laurelkeys wants to merge 13 commits into
Draft
Preview post-processing stage changes in appleseed.studio#2885laurelkeys wants to merge 13 commits into
laurelkeys wants to merge 13 commits into
Conversation
Member
|
Franz and I just tested your PR. Amazing work ! We are concerned about the processing time taken by the bloom effect or other future resource-intensive effect. I think we already discussed about this, but maybe you can add a checkbox to control the preview ? Like the following : That checkbox won't be visible when first adding the effect, as the preview doesn't work there. |
oktomus
marked this pull request as ready for review
September 28, 2020 19:25
oktomus
marked this pull request as draft
October 5, 2020 06:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This adds a rendered preview when parameter values are changed for post-processing stages (similar to the current behavior of
False Colors).Note that only the effect that is being changed is applied for preview (i.e. if there are multiple stages, this won't show all of them).
Obs.: as of right now, when you add a new effect it doesn't work untill you click
OKto add it and then edit its parameters. This should be fixed before this PR is merged.Other "nice-to-have"s are: