Add optional group/ldap-ou check#7
Open
klingtnet wants to merge 4 commits intoapprenda-kismatic:masterfrom
Open
Add optional group/ldap-ou check#7klingtnet wants to merge 4 commits intoapprenda-kismatic:masterfrom
klingtnet wants to merge 4 commits intoapprenda-kismatic:masterfrom
Conversation
added 4 commits
September 1, 2017 10:38
This adds the following command line flag `--ldap-group` to set the group a user is checked against. Make sure to not specify a organizational unit `ou` in your base DN because otherwise either user or group searches will not work, at least if `ou` is set to `people` or `groups`.
Group member check is not tested.
Rename group to the LDAP specific term _Organizational Unit_, or short OU to avoid misinterpretations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an optional command line flag
--ldap-ouwhich when specified checks if a user is member of the given group—or in LDAP terms organizational unit (ou).Authorization fails if a group was specified and the user is not a member.
If no flag was given then the check is ignored.