fix: negative scale breaking collision shapes#502
Open
xingzihai wants to merge 1 commit intoappsinacup:mainfrom
Open
fix: negative scale breaking collision shapes#502xingzihai wants to merge 1 commit intoappsinacup:mainfrom
xingzihai wants to merge 1 commit intoappsinacup:mainfrom
Conversation
When body scale changes, shapes were being destroyed and recreated which caused temporary collision issues during the transition. This fix updates shape transforms instead of recreating shapes, which preserves collision detection during scale changes. The issue was that characters with negative scale (e.g., (-1, 1)) would pass through objects because the collider was briefly unavailable during recreation. Fixes appsinacup#398
Ughuuu
approved these changes
Apr 3, 2026
Contributor
|
Lint the code either manually or by running: https://github.com/appsinacup/godot-rapier-physics/blob/main/scripts/lint.sh Or something equivalent. If not, I can run it locally and update your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #398
This PR fixes the issue where setting negative scale on a collision shape would break collision detection.
Changes
Testing
Fixes #398