Skip to content

Conversation

@HarshMN2345
Copy link
Member

@HarshMN2345 HarshMN2345 commented Jan 13, 2026

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Summary by CodeRabbit

  • Chores
    • Updated sitemap namespace configuration declarations.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 13, 2026

Walkthrough

The change updates XML namespace declarations in server/sitemap.js by replacing HTTPS-based URLs with HTTP-based URLs for sitemap-related namespaces. The modifications affect both the sitemap index and urlset namespace definitions. No functional logic, control flow, or exported public declarations are altered.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: updating sitemap XML namespaces from HTTPS to HTTP-based URLs to align with the official sitemap specification.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9f28d54 and e7442d5.

📒 Files selected for processing (1)
  • server/sitemap.js
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: tests
  • GitHub Check: build
  • GitHub Check: assets
🔇 Additional comments (2)
server/sitemap.js (2)

75-75: LGTM — Namespace URIs align with official sitemap specification.

The official sitemaps.org protocol specifies http://www.sitemaps.org/schemas/sitemap/0.9 as the canonical namespace URI. All namespace declarations in the file (lines 75 and 127–132) correctly use HTTP URIs matching the specification. XML namespace URIs are identifiers and do not require URL resolution.


127-132: LGTM — All namespace URIs aligned with official specifications.

These namespace changes are correct:

  • http://www.sitemaps.org/schemas/sitemap/0.9 — official sitemap protocol namespace
  • http://www.w3.org/1999/xhtml — canonical W3C XHTML namespace
  • Google extension namespaces (mobile, news, image, video) — use HTTP per Google's documentation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects the XML namespace declarations in sitemap files from HTTPS to HTTP, aligning them with the official sitemap protocol specification. XML namespaces are identifiers rather than URLs to be fetched, and the official specifications use HTTP.

Changes:

  • Updated sitemap index namespace declaration from HTTPS to HTTP
  • Updated all six urlset namespace declarations (main namespace plus xhtml, mobile, news, image, and video extensions) from HTTPS to HTTP

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ItzNotABug ItzNotABug merged commit 73bdc62 into main Jan 14, 2026
12 checks passed
@ItzNotABug ItzNotABug deleted the fix-sitemaps-namespacing branch January 14, 2026 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants