feat(docker): verify reviewed changes are already implemented in bundle-aware tool setup#41
Closed
feat(docker): verify reviewed changes are already implemented in bundle-aware tool setup#41
Conversation
- DockerToolManager: add bundle_dir support for installing from app bundle xbin/ before CDN download. Uses temp file + atomic rename to avoid symlink attacks. Binary tools are SHA-verified; tgz tools trust the code-signed bundle. - Fix tgz cache validation: use sidecar .sha256 files instead of comparing extracted binary hash against archive hash (which always mismatches). - CLI docker setup: auto-detect xbin/ in app bundle, support --format json for NDJSON progress streaming. - validate_all: use sidecar-aware validation for tgz tools.
7 tasks
Copilot
AI
changed the title
[WIP] Add auto-install for CLI tools on Desktop launch
feat(docker): verify reviewed changes are already implemented in bundle-aware tool setup
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR review comments on the bundle-aware Docker tool installation flagged three security/correctness issues. All three were already addressed in the current branch — this PR confirms their implementation is correct and complete.
Fixes confirmed in
crates/arcbox-docker-tools/src/manager.rstry_install_from_bundlewrites todest.bundle.tmp(never following a pre-existing symlink atdest), verifies the checksum, then atomicallyrename()s into placeis_cachednow reads a{name}.sha256sidecar for tgz-format tools (e.g.docker) instead of hashing the extracted binary against the archive checksum;write_sidecarwrites this file after every successful install✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.