Open
Conversation
Signed-off-by: emirot <emirot.nolan@gmail.com>
Bundle ReportBundle size has no change ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1021 +/- ##
==========================================
- Coverage 50.74% 49.45% -1.30%
==========================================
Files 51 51
Lines 5492 5492
==========================================
- Hits 2787 2716 -71
- Misses 2407 2477 +70
- Partials 298 299 +1 ☔ View full report in Codecov by Sentry. |
crenshaw-dev
reviewed
Feb 9, 2026
| layout: | ||
| - go.kubebuilder.io/v4 | ||
| projectName: promoter | ||
| projectName: gitops-promoter |
Contributor
There was a problem hiding this comment.
Is this change gonna cause other changes in this repo if/when we run kubebuilder update commands?
Contributor
Author
There was a problem hiding this comment.
mmm not that straightforward
➜ gitops-promoter git:(main) kubebuilder alpha update --from-version 4.2.0
WARN No --from-branch specified, using 'main' as default
INFO Checking if is a git repository
INFO Checking if branch has uncommitted changes
INFO Binary version available version=v4.2.0
INFO Binary version available version=v4.11.1
INFO Checking out base branch branch=main
INFO Preparing Ancestor branch branch_name=tmp-ancestor-09-02-26-10-29
ERROR Update failed error=failed to prepare ancestor branch: failed to cleanup the tmp-ancestor-09-02-26-10-29 : failed to clean up files: exit status 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update project name
Why
This name will be the name used when generating helm, it does not matter because the name won't be overwritten, but better to change it for concistency.