fix(ci): sonarqube-scan-action downloads Sonar Scanner CLI without verifying (#27079)#27080
Open
dudinea wants to merge 10 commits intoargoproj:masterfrom
Open
fix(ci): sonarqube-scan-action downloads Sonar Scanner CLI without verifying (#27079)#27080dudinea wants to merge 10 commits intoargoproj:masterfrom
dudinea wants to merge 10 commits intoargoproj:masterfrom
Conversation
Signed-off-by: Eugene Doudine <eugene.doudine@octopus.com>
Signed-off-by: dudinea <eugene.doudine@octopus.com>
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #27080 +/- ##
=========================================
Coverage ? 63.35%
=========================================
Files ? 415
Lines ? 56553
Branches ? 0
=========================================
Hits ? 35830
Misses ? 17344
Partials ? 3379 ☔ View full report in Codecov by Sentry. |
reggie-k
reviewed
Mar 31, 2026
Member
reggie-k
left a comment
There was a problem hiding this comment.
Thanks!
Will we need a follow-up PR for renovate/dependabot config to bump the version in 2 places?
…nner-verify-cli-binary Signed-off-by: Eugene Doudine <eugene.doudine@octopus.com>
Signed-off-by: Eugene Doudine <eugene.doudine@octopus.com>
Signed-off-by: Eugene Doudine <eugene.doudine@octopus.com>
Member
Author
updated the PR, now there is no need to change bots' configs for that, tested in the forked repo. |
Signed-off-by: Eugene Doudine <eugene.doudine@octopus.com>
Signed-off-by: Eugene Doudine <eugene.doudine@octopus.com>
Signed-off-by: Eugene Doudine <eugene.doudine@octopus.com>
Signed-off-by: Eugene Doudine <eugene.doudine@octopus.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #27079
This PR provides a workaround for this
sonarqube-scan-actionvulnerabilityuntil it's fixed by the action authors. I'm goind to submit a bug report
to SonarSource.
This PR adds a priliminary step before running the
sonarqube-scan-actionthat uses the manifest in the action source (pinned by commit SHA) to
download CLI binary, verify it's integrity and makes the action use the downloaded
and verified CLI binary.
While this fix is rather complex I hope it is temporary until it fixed upstream.
Checklist: