Skip to content

fix(ui): improve dark mode colors and consistency#27086

Open
faytekin wants to merge 6 commits intoargoproj:masterfrom
faytekin:fix/ui-dark-mode-improvements
Open

fix(ui): improve dark mode colors and consistency#27086
faytekin wants to merge 6 commits intoargoproj:masterfrom
faytekin:fix/ui-dark-mode-improvements

Conversation

@faytekin
Copy link
Copy Markdown

@faytekin faytekin commented Mar 31, 2026

Fixes dark mode issues where argo-ui components still render with light
colors. White tooltips, bright buttons, unreadable text on dark backgrounds etc.

Adds dark-mode-overrides.scss to override argo-ui components that don't
support theming and removes hardcoded inline colors from TSX files. Also
adds body.dark-theme class for styling portaled elements (tooltips,
dropdowns) that render outside the .theme-dark wrapper.

Before / After

Before
Screenshot 2026-03-31 at 16 46 15

Screenshot 2026-03-31 at 16 47 03

After

Screenshot 2026-03-31 at 16 46 29 Screenshot 2026-03-31 at 16 46 50

@faytekin faytekin requested a review from a team as a code owner March 31, 2026 13:49
@bunnyshell
Copy link
Copy Markdown

bunnyshell bot commented Mar 31, 2026

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@faytekin faytekin force-pushed the fix/ui-dark-mode-improvements branch from b2e046d to 619fd1e Compare March 31, 2026 20:24
Copy link
Copy Markdown
Member

@choejwoo choejwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments. Please take a look.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this PR, is DarkModeToggleButton in the logs viewer no longer needed?

Image

Copy link
Copy Markdown
Author

@faytekin faytekin Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Instead of removing it entirely, I've hidden the toggle when the global dark theme is already active. So it only shows up in light mode where it's still useful.

Comment on lines +214 to +217
.login__box,
.login__saml-separator span {
background-color: $dark-theme-background-2;
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these login-related dark mode overrides actually apply? From what I checked, the login page seems to keep the same styling as before.
I may be missing something, but since the login route does not seem to go through Layout, I was wondering whether these styles are actually being applied.

Image

Copy link
Copy Markdown
Author

@faytekin faytekin Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, the login route has noLayout: true so it bypasses Layout. Fixed this by extracting a useBodyTheme hook and calling it from the Login component directly.

Screenshot 2026-04-08 at 01 05 34

faytekin added 2 commits April 8, 2026 00:21
Signed-off-by: Fatih Aytekin <fatih@aytekin.me>
Signed-off-by: Fatih Aytekin <fatih@aytekin.me>
@faytekin faytekin force-pushed the fix/ui-dark-mode-improvements branch from 619fd1e to f3bad36 Compare April 7, 2026 21:22
faytekin added 2 commits April 8, 2026 01:06
Signed-off-by: Fatih Aytekin <fatih@aytekin.me>
Signed-off-by: Fatih Aytekin <fatih@aytekin.me>
@faytekin faytekin force-pushed the fix/ui-dark-mode-improvements branch from 791ef7c to 466919e Compare April 7, 2026 22:07
faytekin added 2 commits April 8, 2026 01:13
Signed-off-by: Fatih Aytekin <fatih@aytekin.me>
Signed-off-by: Fatih Aytekin <fatih@aytekin.me>
@faytekin faytekin force-pushed the fix/ui-dark-mode-improvements branch from c2e14bc to c3115a5 Compare April 7, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants