fix(ui): improve dark mode colors and consistency#27086
Open
faytekin wants to merge 6 commits intoargoproj:masterfrom
Open
fix(ui): improve dark mode colors and consistency#27086faytekin wants to merge 6 commits intoargoproj:masterfrom
faytekin wants to merge 6 commits intoargoproj:masterfrom
Conversation
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
b2e046d to
619fd1e
Compare
choejwoo
reviewed
Apr 7, 2026
Member
choejwoo
left a comment
There was a problem hiding this comment.
I left a few comments. Please take a look.
Member
Author
There was a problem hiding this comment.
Good point. Instead of removing it entirely, I've hidden the toggle when the global dark theme is already active. So it only shows up in light mode where it's still useful.
Comment on lines
+214
to
+217
| .login__box, | ||
| .login__saml-separator span { | ||
| background-color: $dark-theme-background-2; | ||
| } |
Member
There was a problem hiding this comment.
Author
Signed-off-by: Fatih Aytekin <fatih@aytekin.me>
Signed-off-by: Fatih Aytekin <fatih@aytekin.me>
619fd1e to
f3bad36
Compare
Signed-off-by: Fatih Aytekin <fatih@aytekin.me>
Signed-off-by: Fatih Aytekin <fatih@aytekin.me>
791ef7c to
466919e
Compare
Signed-off-by: Fatih Aytekin <fatih@aytekin.me>
Signed-off-by: Fatih Aytekin <fatih@aytekin.me>
c2e14bc to
c3115a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes dark mode issues where argo-ui components still render with light
colors. White tooltips, bright buttons, unreadable text on dark backgrounds etc.
Adds
dark-mode-overrides.scssto override argo-ui components that don'tsupport theming and removes hardcoded inline colors from TSX files. Also
adds
body.dark-themeclass for styling portaled elements (tooltips,dropdowns) that render outside the
.theme-darkwrapper.Before / After
Before

After