feat(argo-cd): Add existingVolumes setting for remaining deployments with emptyDir volumes#2456
feat(argo-cd): Add existingVolumes setting for remaining deployments with emptyDir volumes#2456bodgit wants to merge 2 commits intoargoproj:mainfrom
existingVolumes setting for remaining deployments with emptyDir volumes#2456Conversation
bodgit
requested review from
jmeridth,
mbevc1,
mkilchhofer,
pdrastil,
tico24 and
yu-croco
as code owners
|
FYI |
|
FYI: The CI is fixed now. 👍 |
bodgit
force-pushed
the
existing-volumes
branch
from
e19c4ae to
dcc068f
Compare
|
@yu-croco Rebased and all tests now pass. |
charts/argo-cd/templates/argocd-application-controller/statefulset.yaml
Outdated
Show resolved
Hide resolved
…s with emptyDir volumes Signed-off-by: Matt Dainty <matt@bodgit-n-scarper.com>
bodgit
force-pushed
the
existing-volumes
branch
from
dcc068f to
d0cf96f
Compare
Signed-off-by: Matt Dainty <matt@bodgit-n-scarper.com>
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Probably needs rebasing rather than closing? 🤔 |
|
Hi @bodgit , can you please fetch latest remote diff and resolve conflicts? |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
not stale |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
5 participants
#2410 added the
existingVolumessetting for the repo-server component. This PR adds an equivalent setting to the other Argo CD components that haveemptyDirvolumes in their deployment so you can either use a PVC or further tune theemptyDirvolume withsizeLimitparameters, etc. (which is what I do).Checklist: