chore(argo-cd): Align haproxy connections default timeout with Argo CD redis client#3244
Open
OpenGuidou wants to merge 1 commit intoargoproj:mainfrom
Open
chore(argo-cd): Align haproxy connections default timeout with Argo CD redis client#3244OpenGuidou wants to merge 1 commit intoargoproj:mainfrom
OpenGuidou wants to merge 1 commit intoargoproj:mainfrom
Conversation
OpenGuidou
requested review from
jmeridth,
mbevc1,
mkilchhofer,
pdrastil,
tico24 and
yu-croco
as code owners
OpenGuidou
changed the title
Member
|
Thanks for this, but this won't get released until it has been released upstream. |
Author
This is in fact a fix to make it work as long as we don't have the upstream settings. |
…D redis client Signed-off-by: OpenGuidou <guillaume.doussin@gmail.com>
yu-croco
added
the
awaiting-upstream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to argoproj/argo-cd#22489.
Pending the possibility to customize the client timeout on Argo CD side, this change aligns the connection timeout settings with HA proxy so that clients are not disconnected when it happens.
Checklist: