feat(argo-cd): adding httproute support to applicationset controller's webhook feature#3672
Open
skluther wants to merge 1 commit intoargoproj:mainfrom
Open
feat(argo-cd): adding httproute support to applicationset controller's webhook feature#3672skluther wants to merge 1 commit intoargoproj:mainfrom
skluther wants to merge 1 commit intoargoproj:mainfrom
Conversation
skluther
requested review from
jmeridth,
mbevc1,
mkilchhofer,
pdrastil,
tico24 and
yu-croco
as code owners
skluther
force-pushed
the
feat/argo-cd-applicationset-httproute
branch
from
b5887ae to
22ca221
Compare
skluther
force-pushed
the
feat/argo-cd-applicationset-httproute
branch
from
22ca221 to
214eb62
Compare
…s webhook support Signed-off-by: Stephen Kluthe <stephen.kluthe@goradar.com>
skluther
force-pushed
the
feat/argo-cd-applicationset-httproute
branch
from
214eb62 to
251fc87
Compare
Author
|
@tico24 would I be able to get an approval for the workflow that requires it? Just want to make sure I'm still paying attention if there are changes that come up. |
jmeridth
requested changes
Jan 21, 2026
| @@ -28,3 +28,5 @@ annotations: | |||
| artifacthub.io/changes: | | |||
| - kind: changed | |||
Member
There was a problem hiding this comment.
Please remove the old change. Keep only your change.
| backendRefs: | ||
| - group: '' | ||
| kind: Service | ||
| name: {{ include "argo-cd.applicationSet.fullname" . }} |
| apiVersion: gateway.networking.k8s.io/v1 | ||
| kind: HTTPRoute | ||
| metadata: | ||
| name: {{ include "argo-cd.applicationSet.fullname" . }} |
|
Sorry this pull request stays unchanged more than one month @skluther if you have not enough time to update it. I can do it if you prefer. |
Author
|
I can take a look at it tomorrow, sorry, I don’t have notifications on so I missed the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds gateway api support for the applicationset controller webhook endpoint.
Changes:
.server.with.applicationSet.Please let me know if you need anything changed.
Also, for the bottom item of the checklist do I just leave that unchecked until the check action is approved?
Checklist: