feat(argo-cd): Adding "appProtocol" to HTTP service port of argocd-server#3716
Closed
gaffneyd4 wants to merge 1 commit intoargoproj:mainfrom
Closed
feat(argo-cd): Adding "appProtocol" to HTTP service port of argocd-server#3716gaffneyd4 wants to merge 1 commit intoargoproj:mainfrom
gaffneyd4 wants to merge 1 commit intoargoproj:mainfrom
Conversation
…rver Signed-off-by: Derek Gaffney <17263955+gaffneyd4@users.noreply.github.com>
7e31e19 to
575c437
Compare
Author
|
I just noticed that this PR might possibly duplicate the efforts in #3585 |
Author
|
The existing HTTP port needs to remain supporting HTTP/1.1 for handling requests from the browser. Unencrypted HTTP can't support both HTTP/1.1 and prior knowledge h2c. The correct approach will be to add an extra port for h2c that gRPC can use (or optionally repurpose the https port for h2c gRPC use when the server is running with --insecure mode). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it possible to configure appProtocol for the
httpport.Motivation: Supports use case of configuring prior knowledge h2c for gRPC support (used by argocd CLI) when argocd-server is not configured to listen with HTTPS (
--insecure). When configured properly, proxies like envoy and istio support HTTP/2 "prior knowledge" (h2c) for upstream connections (istio example).Checklist: