feat(argo-cd): Allow configuring external redis endpoint from secret#3734
Open
jdcmarques wants to merge 2 commits intoargoproj:mainfrom
Open
feat(argo-cd): Allow configuring external redis endpoint from secret#3734jdcmarques wants to merge 2 commits intoargoproj:mainfrom
jdcmarques wants to merge 2 commits intoargoproj:mainfrom
Conversation
jdcmarques
force-pushed
the
feat-allow-extenal-redis-server
branch
from
f391f63 to
af06b6f
Compare
jdcmarques
changed the title
jdcmarques
requested review from
jmeridth,
mbevc1,
mkilchhofer,
pdrastil,
tico24 and
yu-croco
as code owners
Signed-off-by: Jose Marques <jose.marques.fend@gmail.com>
Signed-off-by: Jose Marques <jose.marques.fend@gmail.com>
jdcmarques
force-pushed
the
feat-allow-extenal-redis-server
branch
from
f4be196 to
f83df02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
We are using Argo CD with AWS Elasticache, our Elasticache is provisioned via crossplane alongside the chart.
To be able to correctly point Argo we need to do two installs, or have Elasticache created separately because of the endpoint.
With this change we allow the redis endpoint when using
externalRedisto be passed from the secret, it will be up to the user to ensure it is inhost:portformatFixes #3735
Checklist: