Skip to content

fix(argo-workflows): Allow controller to edit workflowartifactgctask's finalizers#3741

Draft
kiblik wants to merge 1 commit intoargoproj:mainfrom
kiblik:main
Draft

fix(argo-workflows): Allow controller to edit workflowartifactgctask's finalizers#3741
kiblik wants to merge 1 commit intoargoproj:mainfrom
kiblik:main

Conversation

@kiblik
Copy link
Copy Markdown
Contributor

@kiblik kiblik commented Feb 20, 2026

Reason: I wanted to use ArtifactGC but opperation was failing with

time="2026-02-20T20:01:48.730Z" level=error msg="failed to GC artifacts" error="failed to create pod: pods \"...\" is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on: , <nil>" namespace=... workflow=...

I locally tested adding the mentioned permission, and it looks it fix the issue.


Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • I have created a separate pull request for each chart according to pull requests
  • My build is green (troubleshooting builds).

Copy link
Copy Markdown
Member

@tico24 tico24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants