fix(argo-workflows): add cronworkflows finalizers to argo-server role

[kunal-511]

Fix: #3691

Checklist:

• I have bumped the chart version according to versioning
• I have updated the documentation according to documentation
• I have updated the chart changelog with all the changes that come with this pull request according to changelog.
• Any new values are backwards compatible and/or have sensible default.
• I have signed off all my commits as required by DCO.
• I have created a separate pull request for each chart according to pull requests
• My build is green (troubleshooting builds).

[tico24]

Is this in the upstream project?

[kunal-511]

Is this in the upstream project?

Yes it is already there
argoproj/argo-workflows@542f866

[kunal-511]

@jmeridth Can you please check this?
Thank you

[tico24]

it seems that this is inexplicably only in the namespaced rbac upstream. You don't get it if you do a full cluster install.

Upstream, for the cluster install, the clusterrole argo-cluster-role gets the permission, which is tied to the argo SA not the argo-server SA. So I'm reluctant to approve this until we understand what's going on here.

[tico24]

I have just chatted with the workflows lead and he believes it should not be present for the server role at all, so it is a bug that is is there on the namespace install. Therefore it shouldn't be in the helm chart either. There's no logical reason in my mind why namespaced and cluster installs would need these permissions. But I am wrong on occasion.

[jmeridth]

@jmeridth Can you please check this? Thank you

@kunal-511 you are already interacting with @tico24, another maintainer. Cheers.