feat(argocd-image-updater): Add missing config values, webhook support, and controller flags#3800
Conversation
0dfbb69 to
c9ab6e0
Compare
| - kind: fixed | ||
| description: Remove command override in deployment to allow Dockerfile ENTRYPOINT with tini init process to prevent zombie processes | ||
| - kind: added | ||
| description: Add missing config values (log.format, interval, max_concurrent_apps, max_concurrent_reconciles, argocd.namespace) |
There was a problem hiding this comment.
Put this PR into draft. Re add the PR checklist that you allowed your LLM to delete and follow it please.
|
Thanks for flagging the GenAI policy — I've read through it. I used Claude Code as a coding assistant, but the changes are based on my own review of the argocd-image-updater controller source where I identified gaps between upstream CLI flags/ConfigMap keys and what I've put the PR in draft for now — happy to mark it ready for review whenever you're comfortable with it. |
69a2d82 to
bef1c1b
Compare
…t, and controller flags - Add discoverable config values: log.format, interval, max_concurrent_apps, max_concurrent_reconciles, argocd.namespace - Add webhook configuration: webhook.enable, webhook.port, webhook.ratelimit-allowed - Wire Aliyun ACR and CloudEvents webhook secret env vars in deployment - Add metricsSecure and enableHTTP2 as first-class controller args - Wire health-probe-bind-address to containerPorts.health value Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Ilia <ilia.lazebnik@gmail.com>
…ptional These flags only apply to the new controller-runtime based `run` command and should not be rendered unless explicitly set by the user. Default to empty string so the flags are omitted entirely when not configured. Signed-off-by: Ilia Lazebnik <ilia.lazebnik@gmail.com> Signed-off-by: Ilia <ilia.lazebnik@placer.ai>
bef1c1b to
dc2f18a
Compare
Signed-off-by: Ilia Lazebnik <ilia.lazebnik@gmail.com> Signed-off-by: Ilia <ilia.lazebnik@placer.ai>
Signed-off-by: Ilia Lazebnik <ilia.lazebnik@gmail.com> Signed-off-by: Ilia <ilia.lazebnik@placer.ai>
Due to the following reasons, shall we follow as argo-cd's way instead of adding all configs?
WDYT? 😄 @mkilchhofer @jmeridth @tico24 |
Yep, that was our / my idea when I upgraded the AIU to 1.0 (PR was created by Renovate): |
Checklist:
Summary
The argocd-image-updater chart (v1.1.3) has several CLI flags and ConfigMap keys that are wired in the deployment template but missing from
values.yaml, making them undiscoverable. Additionally, newer webhook secrets from v1.1.0 (CloudEvents for ECR) are not wired at all.This PR adds first-class support for:
log.format,interval,max_concurrent_apps,max_concurrent_reconciles,argocd.namespaceare all read via env vars from the ConfigMap but had no correspondingvalues.yamlentrieswebhook.enable,webhook.port,webhook.ratelimit-allowedwere wired as env vars but had no config values to populate themALIYUN_ACR_WEBHOOK_SECRETandCLOUDEVENTS_WEBHOOK_SECRET(new in v1.1.0 for ECR CloudEvents support) were not wired in the deployment templatemetricsSecureandenableHTTP2are now first-class values instead of requiringextraArgs--health-probe-bind-addressis now wired tocontainerPorts.healthinstead of being hardcodedAll new config values default to empty strings (no-op in the ConfigMap) and boolean flags match upstream defaults, so this is fully backwards compatible.
Test plan
helm templatewith defaults renders correctly (no extra args, empty config values are no-op)helm templatewithmetricsSecure=falseandenableHTTP2=truerenders correct CLI argshelm templatewith webhook config values renders them in the ConfigMap