feat(argo-cd): add VPA support for all components#3817
Open
rd-michel wants to merge 2 commits intoargoproj:mainfrom
Open
feat(argo-cd): add VPA support for all components#3817rd-michel wants to merge 2 commits intoargoproj:mainfrom
rd-michel wants to merge 2 commits intoargoproj:mainfrom
Conversation
Add VerticalPodAutoscaler templates and values for all Argo CD components: application-controller, server, repo-server, applicationset-controller, notifications-controller, dex, redis, and commit-server. All VPA resources are disabled by default (enabled: false) and support configuring labels, annotations, updateMode, and containerPolicy. The existing application-controller VPA template is used as the reference implementation. Signed-off-by: Michel Mangano <michel.mangano@rewe-group.com>
tomasz-nieczkowski-rewe-digital
approved these changes
Apr 2, 2026
VPA CRDs (autoscaling.k8s.io/v1) are not installed in the kind cluster used for chart-testing, so helm install with vpa-values.yaml fails. Apply the same pattern used for HPA by removing the file before the install step. Signed-off-by: Michel Mangano <michel.mangano@rewe-group.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This contribution was developed with the assistance of GitHub Copilot (AI pair programming). The implementation, testing, and review were guided by a human maintainer.
What this PR does
Adds
VerticalPodAutoscalersupport for all Argo CD components. Previously only theapplication-controllerhad a VPA template. This PR extends it to the remaining components:argocd-serverargocd-repo-serverargocd-applicationset-controllerargocd-notifications-controllerdexredisargocd-commit-serverEach new VPA template follows the existing
application-controllerVPA template as a reference implementation.Changes
vpa.yamlfor each of the 7 components listed abovevalues.yaml: Added avpasection after thepdbsection for each component (same structure ascontroller.vpa):enabled: false— disabled by default, fully backwards compatiblelabels: {}annotations: {}updateMode: InitialcontainerPolicy: {}(with commented examples)ci/vpa-values.yaml: New CI test values file enabling VPA for all componentsChart.yaml: Version bump9.4.17→9.4.18,artifacthub.io/changesupdatedREADME.md: Regenerated viahelm-docsTesting
All CI values files lint cleanly with
helm lint:helm templatewith all VPA flags enabled produces validVerticalPodAutoscalerresources for all 8 components.Checklist: