Fix: no automatic foreign keys referencing partitions#3114
Open
s-sokolko wants to merge 28 commits intoariga:masterfrom
Open
Fix: no automatic foreign keys referencing partitions#3114s-sokolko wants to merge 28 commits intoariga:masterfrom
s-sokolko wants to merge 28 commits intoariga:masterfrom
Conversation
…icats Feature: no automatic foreign keys referencing partitions
Member
|
Thanks for the contribution, @s-sokolko. However, I won’t merge this as it conflicts with our current work on supporting partitions (which should be released soon). I appreciate your effort. |
This reverts commit c2c3c24.
eidn133
approved these changes
Dec 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
atlas migrate diffand the schema contains partitioned tables the autogenerated migration sometimes contains duplicate foreign key constraints. It happens when there is a foreign key in DB schema that references a partitioned table. In this case the foreign key search sql filters tables by the source table of the FK only, But we have to filter also by the target table, because if we don't the query also gives us all the partitions of tha partitioned table aprat from the partitioned table itself.I've faced this situation using Postgres. My fix adds checks and some query formatting.