cmd/atlas/internal/cmdapi: add command line flag for lock name#3475
Open
hanurimies wants to merge 1 commit intoariga:masterfrom
Open
cmd/atlas/internal/cmdapi: add command line flag for lock name#3475hanurimies wants to merge 1 commit intoariga:masterfrom
hanurimies wants to merge 1 commit intoariga:masterfrom
Conversation
Member
|
Thanks for the contribution, @hanurimies. I'm not sure this is how we want to resolve this issue. We already have a unique resource per directory/migration, which is the revisions table. We can handle it without exposing this to the user and making the API error-prone. I suggest you open an issue with this context, and the team will discuss it. We won't be able to accept external contributions in this area because it touches some parts that involve our internal codebase. |
Author
|
Thanks for the quick response! I'll open an issue. Internally we tried this solution and it works, but sure, better to use the more robust solution that you referred to. |
Author
|
Issue: #3476 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our application we use single database and different schemas for each microservice. There are several reasons for using this kind of setup.
The migrate command used a fixed name for the migration lock (PG advisory lock). That caused issues in our application: one microservice running a lenghty migration caused all other microservices to be waiting for the lock to check and run their migrations.
To remedy the situation, this commit makes the lock name to be configurable using a command line flag. Condirered also making the locking to use schema name as lock name, but that might not be what other applications want. Introducing a separate command line flag for the lock name offers the most flexible solution.
The default behaviour is the same as before. If the lock name flag is not given, the old fixed name is used for lock.