Skip to content

[fix] remove destructor in mutex #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skalenji wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[fix] remove destructor in mutex #40

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb8abba
[fix] remove destructor in mutex
Aug 13, 2018
bb01eb2
Merge branch 'master' into fix-exception-thrown-in-mutex-desstruct
arvenil Dec 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions src/Mutex.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,30 +82,6 @@ public function releaseLock()
return false;
}

/**
* Try to release any obtained locks when object is destroyed
*
* This is a safe guard for cases when your php script dies unexpectedly.
* It's not guaranteed it will work either.
*
* You should not depend on __destruct() to release your locks,
* instead release them with `$released = $this->releaseLock()`A
* and check `$released` if lock was properly released
* @throws UnrecoverableMutexException
*/
public function __destruct()
{
while ($this->isAcquired()) {
$released = $this->releaseLock();
if (!$released) {
throw new UnrecoverableMutexException(sprintf(
'Cannot release lock in Mutex __destruct(): %s',
$this->name
));
}
}
}

/**
* Check if Mutex is acquired
*
Expand Down