Skip to content

Horiz spatial domain bugfix & implement more geometry related factories#52

Merged
benbart merged 3 commits into
mainfrom
bbarton/PR-7400
Apr 24, 2026
Merged

Horiz spatial domain bugfix & implement more geometry related factories#52
benbart merged 3 commits into
mainfrom
bbarton/PR-7400

Conversation

@benbart
Copy link
Copy Markdown
Contributor

@benbart benbart commented Apr 22, 2026

Pull Request Checklist

I have:

  • performed a self review of my code I&A code style
    • Resources and Data Structures are sorted by ABC or a defined sorting pattern
  • updated the documentation accordingly
  • verified required action checks are passing
  • bumped the version number as appropriate

@benbart benbart force-pushed the bbarton/PR-7400 branch 2 times, most recently from f871a6f to 59f8b88 Compare April 22, 2026 23:34
@benbart benbart changed the title Implement more geometry related factories Horiz spatial domain bugfix & implement more geometry related factories Apr 22, 2026
Copy link
Copy Markdown
Contributor

@reweeden reweeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If needed for development you can always point the pinned version of mandible in your requirements.in file to a branch or commit hash instead of a release tag. That way you can make sure you've got all the changes you need for your work before making a new mandible release which should reduce the need for making multiple releases and updating the dependencies in CIRRUS multiple times.

Overall looks good, just some small consistency things.

Comment thread mandible/umm_classes/factory.py Outdated
Comment thread mandible/umm_classes/factory.py
Comment thread mandible/umm_classes/factory.py Outdated
Comment thread mandible/umm_classes/factory.py Outdated
@benbart benbart requested a review from reweeden April 23, 2026 20:45
Copy link
Copy Markdown
Contributor

@reweeden reweeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, looks great! Seems the branch needs to be rebased onto main though Nevermind

@benbart benbart merged commit 8cb8753 into main Apr 24, 2026
11 checks passed
@benbart benbart deleted the bbarton/PR-7400 branch April 24, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants