Red text is barely legible when using a dark theme by Claude · Pull Request #106 · ashaduri/gsmartcontrol

Claude · 2026-03-04T21:50:41Z

Replace Gtk::Main::level() == 0 guard with null check on Gtk::Settings::get_default() in is_dark_theme_active() — fixes dark theme detection during initial UI construction (before Gtk::Main::run())
Add fallback #FF0000 in self-test error color path to always visually emphasize errors even if color lookup fails

Original prompt

This section details on the original issue you should resolve

<issue_title>Red text is barely legible when using a dark theme.</issue_title>
<issue_description>Version and Environment

GSmartControl version: [Are you using the latest released version or git?] 1.1.4

OS: [e.g. openSUSE Linux 15.4] Manjaro Gnome

Is your feature request related to a problem? Please describe.
Red text is barely legible, when using a dark theme like adw-gtk3-dark.

Describe the solution you'd like
A lighter red (closer to pink) text when using a dark theme.</issue_description>

Comments on the Issue (you are @claude[agent] in this section)

Fixes Red text is barely legible when using a dark theme. #48

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Co-authored-by: ashaduri <2302268+ashaduri@users.noreply.github.com>

- Guard theme detection with Gtk::Main::level() check to avoid crashes in non-GUI executables - Use narrow headers (gtkmm/settings.h, gtkmm/main.h) instead of umbrella gtkmm.h - Return early from app_property_get_label_highlight_color() for WarningLevel::None Co-authored-by: ashaduri <2302268+ashaduri@users.noreply.github.com>

Co-authored-by: ashaduri <2302268+ashaduri@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

ashaduri · 2026-03-07T15:39:12Z

@copilot apply changes based on the comments in this thread

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Co-authored-by: ashaduri <2302268+ashaduri@users.noreply.github.com>

- Guard theme detection with Gtk::Main::level() check to avoid crashes in non-GUI executables - Use narrow headers (gtkmm/settings.h, gtkmm/main.h) instead of umbrella gtkmm.h - Return early from app_property_get_label_highlight_color() for WarningLevel::None Co-authored-by: ashaduri <2302268+ashaduri@users.noreply.github.com>

Co-authored-by: ashaduri <2302268+ashaduri@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…into claude/fix-red-text-legibility # Conflicts: # src/applib/warning_colors.h # src/gui/gsc_info_window.cpp

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Copilot · 2026-03-08T18:10:49Z

+				// Use the same color as Alert level warnings for consistency
+				if (app_property_get_label_highlight_color(WarningLevel::Alert, alert_color) && !alert_color.empty()) {
+					result_main_msg = "<span color=\"" + alert_color + "\">"s + result_main_msg + "</span>";
+				}


In the self-test error highlighting path, app_property_get_label_highlight_color is being called with the old signature (missing the new dark_mode boolean). This will fail to compile after the API change in warning_colors.h. Also, if the color lookup fails, the message is left uncolored, but the PR description indicates there should be a #FF0000 fallback to ensure errors are always emphasized. Update the call to pass gui_is_dark_theme_active() (or a cached dark_mode) and apply a #FF0000 fallback when the lookup fails/returns empty.

Suggested change

// Use the same color as Alert level warnings for consistency

if (app_property_get_label_highlight_color(WarningLevel::Alert, alert_color) && !alert_color.empty()) {

result_main_msg = "<span color=\"" + alert_color + "\">"s + result_main_msg + "</span>";

}

const bool dark_mode = gui_is_dark_theme_active();

// Use the same color as Alert level warnings for consistency,

// falling back to red if lookup fails or returns empty.

if (!app_property_get_label_highlight_color(WarningLevel::Alert, dark_mode, alert_color) || alert_color.empty()) {

alert_color = "#FF0000";

}

result_main_msg = "<span color=\"" + alert_color + "\">"s + result_main_msg + "</span>";

Initial plan

d110c7a

Claude AI assigned Claude and ashaduri Mar 4, 2026

Claude started work on behalf of ashaduri March 4, 2026 21:50 View session

Implement theme-aware red text colors for dark theme legibility

f692e28

Co-authored-by: ashaduri <2302268+ashaduri@users.noreply.github.com>

Claude AI changed the title ~~[WIP] Fix red text legibility in dark theme~~ Fix red text legibility on dark GTK themes Mar 4, 2026

Claude finished work on behalf of ashaduri March 4, 2026 21:57

ashaduri requested a review from Copilot March 6, 2026 14:24

Copilot started reviewing on behalf of ashaduri March 6, 2026 14:25 View session

This comment was marked as resolved.

Sign in to view

Claude started work on behalf of ashaduri March 6, 2026 14:32 View session

This comment was marked as outdated.

Sign in to view

Claude AI changed the title ~~Fix red text legibility on dark GTK themes~~ Addressing PR comments Mar 6, 2026

Claude finished work on behalf of ashaduri March 6, 2026 14:37

Claude started work on behalf of ashaduri March 6, 2026 14:37 View session

Claude finished work on behalf of ashaduri March 6, 2026 14:39

Claude started work on behalf of ashaduri March 6, 2026 19:03 View session

Revert to umbrella gtkmm.h include per maintainer request

258d06b

Co-authored-by: ashaduri <2302268+ashaduri@users.noreply.github.com>

This comment was marked as outdated.

Sign in to view

Claude finished work on behalf of ashaduri March 6, 2026 19:08

ashaduri requested review from ashaduri and Copilot March 6, 2026 19:12

Copilot started reviewing on behalf of ashaduri March 6, 2026 19:13 View session

This comment was marked as resolved.

Sign in to view

Update src/gui/gsc_info_window.cpp

7e62646

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

ashaduri changed the title ~~Addressing PR comments~~ Red text is barely legible when using a dark theme Mar 7, 2026

ashaduri requested a review from Copilot March 7, 2026 15:33

Copilot started reviewing on behalf of ashaduri March 7, 2026 15:34 View session

Copilot AI reviewed Mar 7, 2026

View reviewed changes

Comment thread src/applib/warning_colors.h Outdated

Comment thread src/gui/gsc_info_window.cpp

Copilot started work on behalf of ashaduri March 7, 2026 15:39 View session

This comment was marked as resolved.

Sign in to view

ashaduri requested a review from Copilot March 7, 2026 16:35

Copilot started reviewing on behalf of ashaduri March 7, 2026 16:35 View session

Copilot AI reviewed Mar 7, 2026

View reviewed changes

Comment thread src/applib/warning_colors.h Outdated

ashaduri and others added 10 commits March 7, 2026 17:39

Update src/applib/warning_colors.h

68032c4

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Add Windows dark mode detection and automatic GTK theme switching (#111)

083936e

Initial plan

ef30450

Implement theme-aware red text colors for dark theme legibility

6de9bb8

Co-authored-by: ashaduri <2302268+ashaduri@users.noreply.github.com>

Revert to umbrella gtkmm.h include per maintainer request

c322e96

Co-authored-by: ashaduri <2302268+ashaduri@users.noreply.github.com>

Update src/gui/gsc_info_window.cpp

06a0a75

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/applib/warning_colors.h

e4c9afe

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Use readable text highlight colors in dark mode.

3642afc

Merge remote-tracking branch 'origin/claude/fix-red-text-legibility' …

a7f0cb7

…into claude/fix-red-text-legibility # Conflicts: # src/applib/warning_colors.h # src/gui/gsc_info_window.cpp

ashaduri marked this pull request as ready for review March 8, 2026 18:04

Copilot AI review requested due to automatic review settings March 8, 2026 18:04

Copilot started reviewing on behalf of ashaduri March 8, 2026 18:05 View session

ashaduri merged commit 79f1c7d into main Mar 8, 2026
4 of 10 checks passed

Copilot AI reviewed Mar 8, 2026

View reviewed changes

Navigation Menu

Red text is barely legible when using a dark theme - #106

Red text is barely legible when using a dark theme#106
ashaduri merged 15 commits into
mainfrom
claude/fix-red-text-legibility

Claude AI commented Mar 4, 2026 •

edited by Copilot AI

Loading

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as resolved.

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

ashaduri commented Mar 7, 2026

Uh oh!

This comment was marked as resolved.

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

-				// Use the same color as Alert level warnings for consistency
-				if (app_property_get_label_highlight_color(WarningLevel::Alert, alert_color) && !alert_color.empty()) {
-					result_main_msg = "<span color=\"" + alert_color + "\">"s + result_main_msg + "</span>";
-				}
+				const bool dark_mode = gui_is_dark_theme_active();
+				// Use the same color as Alert level warnings for consistency,
+				// falling back to red if lookup fails or returns empty.
+				if (!app_property_get_label_highlight_color(WarningLevel::Alert, dark_mode, alert_color) || alert_color.empty()) {
+					alert_color = "#FF0000";
+				}
+				result_main_msg = "<span color=\"" + alert_color + "\">"s + result_main_msg + "</span>";

Conversation

Claude AI commented Mar 4, 2026 • edited by Copilot AI Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comments on the Issue (you are @claude[agent] in this section)

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as resolved.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

ashaduri commented Mar 7, 2026

Uh oh!

This comment was marked as resolved.

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Claude AI commented Mar 4, 2026 •

edited by Copilot AI

Loading