fix(common): reduce serenity dev compose memory overhead#206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Таска
Refs atls/planning#540
Что сделано
modules:/workspace/node_modulesиз dev-контейнеров: текущий compose больше не монтирует legacynode_modulesvolume в PnP-контур.yarnвынесен из default compose в profiletools, чтобы пустойdocker compose upне запускалyarn installи не ловил OOM на вспомогательном контейнере.yarn service dev/yarn renderer dev, безyarn workspace <pkg> <script>trampoline.service devзадан PnPNODE_OPTIONS, чтобы Raijinplugin-serviceне уходил в proxy child Yarn.init: true, чтобы Docker корректно reaped/forwarded child-процессы webpack/app runtime.Как проверять
docker compose config --quietgit diff --checkdocker compose up -d --remove-orphansdocker compose ps -adocker stats --no-stream ...Фактическая проверка
serenity-yarn-1Exited 137сOOMKilled=true,public-gatewayExited 129сOOMKilled=true; baseline Node/watch контейнеров был порядка 430-760 MiB на сервис плюс лишнийyarnhelper.OOMKilled=true;yarnhelper больше не входит в default profile.catalog-serviceс контрактнымentrypoint: yarn: процессное дерево сталоdocker-init -> yarn -> yarn-remote service dev -> app child; Raijin proxy child Yarn не вернулся благодаря PnPNODE_OPTIONS.Не закрыто этим PR
site-local,identity,emailrenderer-контейнеры завершаютсяExited (0)наyarn renderer dev; smoke frontend не считается пройденным.