This repository was archived by the owner on Nov 9, 2024. It is now read-only.
refactor(types): decrease specificity of lifecycle hook return type#1167
Open
J-Michalek wants to merge 1 commit intoatomiks:masterfrom
Open
refactor(types): decrease specificity of lifecycle hook return type#1167J-Michalek wants to merge 1 commit intoatomiks:masterfrom
J-Michalek wants to merge 1 commit intoatomiks:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find it oddly specific and since I am using https://typescript-eslint.io/rules/explicit-function-return-type/ in my projects I have to explicitely say
false | voidinstead of a simple boolean with it every time there is a tooltip that should have aonShowhook condition. Passingtrueshould work the same asvoidas the implementation only checks forfalse.