fix: verify calendar webhook tokens and Zoom timestamp freshness - #942
Open
valvesss wants to merge 1 commit into
Open
fix: verify calendar webhook tokens and Zoom timestamp freshness#942valvesss wants to merge 1 commit into
valvesss wants to merge 1 commit into
Conversation
Require Microsoft clientState and Google channel token to match the calendar-bound secret set at subscription creation, keep processing valid Microsoft batch items after invalid ones, and reject stale Zoom webhook timestamps with constant-time signature compare. Co-authored-by: Vitor Alves <vitoralvesinfo@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clientState({"calendar_id": …}); UUID alone ignored; batch usescontinuenot earlyreturn.X-Goog-Channel-Token.hmac.compare_digest.None(no AttributeError).Test plan
Local (Mimir): Postgres 15.3 + Redis 7.
compare_digest)Still for CI: same modules in project Docker test env.
Contribution from Cold Code Labs · authored via Brokk · co-authors in commit trailers.