fix: use real links for dashboard navigation - #994
Open
ppeerttu wants to merge 3 commits into
Open
Conversation
ppeerttu
changed the title
ppeerttu
marked this pull request as ready for review
September 7, 2026 13:12
Sidebar nav items and list rows (bots, calendars, calendar events) used hx-get on elements without an href, so they could not be opened in a new tab or copied as links. Replace them with real anchors and hx-boost, which keeps the existing partial content swap for normal clicks while leaving modified clicks to the browser.
The inline click handler marked a nav item active on any click, including cmd/ctrl-click, which opens a new tab and leaves the current page unchanged. Update the active item from the current URL on load and after htmx pushes or restores history.
Bootstrap tab buttons in page content also use .nav-link, so the unscoped selector cleared their active state on load and history restore. Bump version to 1.72.1.
ppeerttu
force-pushed
the
fix/dashboard-real-links
branch
from
September 10, 2026 12:19
fd3190a to
53183c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sidebar items and rows in the bot, calendar, and calendar event lists navigate via
hx-geton elements without anhref. That means they can't be opened in a new tab, middle-clicked, or copied as links.This switches them to real anchors with
hx-boost. Normal clicks still swap only the content pane as before; modified clicks are left to the browser. Row clicks now ignore clicks on links inside the row so a click on the new anchor doesn't fire twice.Templates only, no server changes.
Screen recording
Demonstrating the nav links and bot listing support properly e.g. opening on new tab.
Screen.Recording.2026-09-07.at.10.28.54.mov