Skip to content

Fix upload ratio display for Transmission special cases#101

Merged
austin-smith merged 2 commits intomainfrom
fix-negative-ratio-display
Mar 23, 2026
Merged

Fix upload ratio display for Transmission special cases#101
austin-smith merged 2 commits intomainfrom
fix-negative-ratio-display

Conversation

@austin-smith
Copy link
Copy Markdown
Owner

Summary

Fixes per-torrent upload ratio handling by preserving Transmission’s raw upload-ratio sentinels in the model and rendering them intentionally in the UI.

Changes

  • interpret Transmission’s upload-ratio sentinels explicitly:
    • 1 -> ratio unavailable
    • 2 -> uploaded bytes without downloaded bytes
  • expose a semantic TorrentUploadRatio instead of treating every raw value as a numeric ratio
  • update torrent ratio UI to render from that semantic state
  • show unavailable ratios as None
  • show the uploaded-without-download case as 1.00+ with a full green ring
  • leave normal numeric ratios unchanged
  • leave aggregate/global ratio displays unchanged

@austin-smith austin-smith merged commit eba3cca into main Mar 23, 2026
3 checks passed
@austin-smith austin-smith deleted the fix-negative-ratio-display branch March 23, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant