Conversation
|
Thanks for providing this. Question why do you need |
|
Hello @pamapa , excuse me for the late answer - unfortanetly I was ill and thus not able to answer asap. We mostly use signinRedirect and ocassionally signinPopup. So as you said, we too only need these. Based on you comment I assume, it would be sufficient to pass either signinRedirect or signinPopup as options to the hook. Update: I adjusted the pull request to only allow signinRedirect and signinPopup as options. |
💡: Fix tsdoc based on api extractor warnings
| type UseAutoSignInReturn = { | ||
| isLoading: boolean; | ||
| isAuthenticated: boolean; | ||
| isError: boolean; |
There was a problem hiding this comment.
Lets use the same name/type for error as already used in useAuth: error?: Error;
There was a problem hiding this comment.
Sure, I changed it to return the error as in useAuth instead and thus adapted the type to Pick return types from the already defined AuthState interface.
Please check if you are happy with that🙂
|
looks good, there is one last small thing remaining (see above) |
Closes/fixes #1475
Checklist