Adding ros2_socketcan_msgs#26
Adding ros2_socketcan_msgs#26xmfcx merged 2 commits intoautowarefoundation:mainfrom JWhitleyWork:add-canfd-msgs
Conversation
kenji-miyake
left a comment
kenji-miyake
left a comment
There was a problem hiding this comment.
Please let me confirm several items.
|
@kenji-miyake or @mitsudome-r friendly ping. |
Signed-off-by: Joshua Whitley <whitleysoftwareservices@gmail.com>
kenji-miyake
left a comment
kenji-miyake
left a comment
There was a problem hiding this comment.
@JWhitleyWork I'm so sorry. I was extremely busy recently. 🥺
Seeing the discussions between other developers, it looks good to me.
Could you consider whether to use uint8[<=64] or not based on this comment?
#26 (comment)
|
@xmfcx @mitsudome-r Could you also review this PR? 🙏 |
Done. |
Signed-off-by: Joshua Whitley <josh@electrifiedautonomy.com>
xmfcx
left a comment
xmfcx
left a comment
There was a problem hiding this comment.
I've also read the related issue and the ros_canopen PR and I think this solution is good.
|
@JWhitleyWork Is it better to create new release? |
Not yet. I need to actually add CAN-FD support to |
7 participants
Per #21, this adds a new package,
ros2_socketcan_msgs. This is per option 3 in that issue.