Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

adapt to pixi5#6

Open
wingcd wants to merge 6 commits intoavgjs:masterfrom
wingcd:master
Open

adapt to pixi5#6
wingcd wants to merge 6 commits intoavgjs:masterfrom
wingcd:master

Conversation

@wingcd
Copy link

@wingcd wingcd commented Apr 8, 2020

1.adapt to pixi5
2.change to typescript

@Icemic
Copy link
Contributor

Icemic commented Apr 9, 2020

Thank you for your kind!

However there're some steps to do:

  1. please split your pull request to several ones, ensuring that each pr only contains one kind of change. And keep it stable (instead of pushing new commits steadily to master).
  2. tell me why you change rollup to webpack? and how about the test?
  3. please keep code style as origin
  4. remove .vscode folder
  5. use official pixijs type defination instead of copy yourself's
  6. add more description to tell me what and how you did.
  7. It's UNACCEPTABLE you remove the LICENSE file

Since it's quite a big change, it may cost quite a time to merge them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants