fix(cli): hotswap ECS flags result in SerializationException: STRING_VALUE cannot be converted to Integer
#973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change hotswap-ecs-minimum-healthy-percent, hotswap-ecs-maximum-healthy-percent, and hotswap-ecs-stabilization-timeout-seconds from string to expected type number type.
dysosmus
had a problem deploying
to
integ-approval
GitHub Actions
Failure
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #973 +/- ##
=======================================
Coverage 87.60% 87.60%
=======================================
Files 72 72
Lines 10069 10069
Branches 1325 1326 +1
=======================================
Hits 8821 8821
Misses 1223 1223
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrgrain
requested changes
Jan 6, 2026
Contributor
mrgrain
left a comment
mrgrain
left a comment
There was a problem hiding this comment.
Build is failing and really we should have a test case here demonstrating the error is fixed.
dysosmus
requested a deployment
to
integ-approval
GitHub Actions
Waiting
dysosmus
requested a deployment
to
integ-approval
GitHub Actions
Waiting
dysosmus
requested a deployment
to
integ-approval
GitHub Actions
Waiting
dysosmus
temporarily deployed
to
integ-approval
GitHub Actions
Inactive
Author
|
Hey @mrgrain the build should be fixed. I've added a unit test for the flag parsing a integration test felts overkill but happy to also add one if it's the preferred. |
mrgrain
changed the title
SerializationException: STRING_VALUE cannot be converted to Integer
mrgrain
approved these changes
Jan 6, 2026
Contributor
mrgrain
left a comment
mrgrain
left a comment
There was a problem hiding this comment.
Agreed, thanks for the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #417 introduced extra hotswap flags. However, when used the flags yield serialisation errors like bellow because the expected type is a number not a string.
This PR changes hotswap-ecs-minimum-healthy-percent, hotswap-ecs-maximum-healthy-percent, and hotswap-ecs-stabilization-timeout-seconds from string to expected type number type.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license