Open
Conversation
valerena
reviewed
Oct 9, 2024
Contributor
valerena
left a comment
There was a problem hiding this comment.
It looks good! The only thing I would ask is if you can add information about this on the README. Probably at the end of "How to configure", a small section describing the existence of this environment variable and what it does.
Author
|
Sure. |
valerena
reviewed
Oct 17, 2024
valerena
previously approved these changes
Oct 21, 2024
Author
|
Same set of tests are failing even without my changes. I even tried by not including the extension in the docker image and still the same tests failing confirming that failures already existed, probably flaky. We may need to adjust the expected values in the tests to account for the longer delays to make the tests more stable. We could consider conditionally checking for long delays only for arm64 arch keeping amd64 values unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Docker for Mac on Apple Silicon MacBooks fail to run SAM containers containing Rust Lambda extensions. This is affecting services that offer SAM based features and customers are blocked. Not sure if the problem is in Docker or Lambda runtime.
cc @valerena
Issues:
Error
Description of changes
Introducing new env variable
AWS_LAMBDA_RIE_DISABLE_EXTENSIONSto disable extensions. With this feature customers can get around the problem by setting this env var in SAM template.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.