Skip to content

Update ML-DSA Wycheproof vectors and add mu verification#2997

Draft
sgmenda wants to merge 9 commits intoaws:mainfrom
sgmenda:more-wycheproof
Draft

Update ML-DSA Wycheproof vectors and add mu verification#2997
sgmenda wants to merge 9 commits intoaws:mainfrom
sgmenda:more-wycheproof

Conversation

@sgmenda
Copy link
Contributor

@sgmenda sgmenda commented Feb 16, 2026

Description of changes:

  • Updates ML-DSA Wycheproof test vectors (added in Integrate Wycheproof ML-DSA test vectors #2973) for all three parameter sets (ML-DSA-44, ML-DSA-65, ML-DSA-87) with additional test cases that include intermediate mu values, bringing us to parity with upstream Wycheproof.
  • Enhances test implementation to verify these intermediate values during signing, making tests more thorough by testing intermediate values.
  • Also updates test vector documentation to clarify duvet annotation requirements (lines must be adjacent and in order) and removes redundant parameter from GitHub workflow.

Call-outs:

Point out areas that need special attention or support during the review process. Discuss architecture or design changes.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@sgmenda sgmenda self-assigned this Feb 16, 2026
@sgmenda sgmenda requested a review from a team as a code owner February 16, 2026 18:29
@sgmenda sgmenda added the vectors Related to third-party test vectors label Feb 16, 2026
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2026

Codecov Report

❌ Patch coverage is 69.44444% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.20%. Comparing base (4738958) to head (bc39e84).

Files with missing lines Patch % Lines
crypto/evp_extra/p_pqdsa_test.cc 69.44% 6 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2997      +/-   ##
==========================================
+ Coverage   78.19%   78.20%   +0.01%     
==========================================
  Files         689      689              
  Lines      122037   122059      +22     
  Branches    17026    17033       +7     
==========================================
+ Hits        95430    95461      +31     
+ Misses      25701    25689      -12     
- Partials      906      909       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sgmenda sgmenda requested a review from justsmth March 11, 2026 16:31
@sgmenda sgmenda marked this pull request as draft March 13, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vectors Related to third-party test vectors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants