Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3096 +/- ##
==========================================
- Coverage 78.16% 78.14% -0.02%
==========================================
Files 689 689
Lines 121643 121676 +33
Branches 16987 16996 +9
==========================================
+ Hits 95077 95089 +12
- Misses 25682 25704 +22
+ Partials 884 883 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
reviewed
Mar 17, 2026
| @@ -0,0 +1,326 @@ | |||
| #!/usr/bin/env bash | |||
Contributor
There was a problem hiding this comment.
- This tests indicates success when run, but returns an error exit status:
...
-- Build files have been written to: /home/justsmth/repos/aws-lc/build_symbol_test
ninja: Entering directory `/home/justsmth/repos/aws-lc/build_symbol_test'
[416/416] Creating library symlink ssl/libssl-awslc.so.0 ssl/libssl-awslc.so
✓ PASS: Build successful
- This test should be added to the CI.
Comment on lines
+93
to
+94
| LIBCRYPTO_SO="${BUILD_DIR}/crypto/libcrypto-awslc.so.0.0.0" | ||
| LIBSSL_SO="${BUILD_DIR}/ssl/libssl-awslc.so.0.0.0" |
Contributor
There was a problem hiding this comment.
libcrypto-awslc.so.0.0.0is hard-coded, but the build produceslibcrypto-awslc.so.1.70.0(theSOFTWARE_VERSIONfrom CMakeLists.txt)?
Comment on lines
+38
to
+41
| print_pass() { | ||
| echo -e "${GREEN}✓ PASS${NC}: $1" | ||
| ((pass_count++)) | ||
| } |
Contributor
There was a problem hiding this comment.
The silent failure is due to set -e and ((pass_count++)), which on first run evaluates to ((0++)) returning exit code 1 and terminating the script.
This should work:
pass_count=$((pass_count + 1))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. For now0reported in our soname and version scripts indicates that it is unstable and open for breakage.Summary
-DENABLE_DIST_PKG=1). All public API symbols are assigned to the AWS_LC_1_0 version namespace (~3,800 libcrypto symbols, ~600 libssl symbols).crypto/libcrypto.txt,ssl/libssl.txt) and GNU ld version scripts (crypto/libcrypto.map,ssl/libssl.map) that serve as the source of truth for exported symbols and their versions.util/read_public_symbols,util/generate_version_script) to extract public symbols from headers and generate version scripts, along with shell scripts (util/generate_initial_version_scripts.sh,util/update_symbol_version.sh) for initial population and version bumps.abidiff.ymlworkflow for incremental (commit-to-commit) and baseline (headers-to-registry) symbol checks, detecting unregistered new APIs and blocking public symbol removals (ABI breaks).linux-multi-arch-omnibus.ymlto validate symbol versioning works end-to-end by building and running tests across Ubuntu 24.04, Amazon Linux 2, and Amazon Linux 2023 on both x86_64 and aarch64.cmake/GenerateVersionScript.cmakewith linker compatibility probing (detects --undefined-version support for lld compatibility).docs/SymbolVersioning.md,BUILDING.md, andREADME.mdcovering build configuration, version evolution, developer workflow, and troubleshooting.Testing
run_symbol_version_test.shvalidates: version scripts are applied, all exported symbols have version tags, no unversioned symbols leak, version definitions are present, and libraries link correctlyrun_dist_pkg_run_tests.shbuilds with -DENABLE_DIST_PKG=ON and runs the full test suiteutil/read_public_symbolsandutil/generate_version_scriptI confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.