nitro-enclaves-allocator.service drop-in: autoload kernel module - #717
Open
jeffmahoney wants to merge 1 commit into
Open
nitro-enclaves-allocator.service drop-in: autoload kernel module#717jeffmahoney wants to merge 1 commit into
jeffmahoney wants to merge 1 commit into
Conversation
This change causes the unit to load the nitro_enclaves kernel module before the service starts. Since the modprobe@.service unit was introduced in systemd v245 and there are releases supported by this project using older versions that don't have it, we conditionally install a drop-in file to avoid the warning about the missing unit file. We use Wants= instead of Requires= so that it's a soft dependency and will attempt to start the service even if the modprobe@ unit is missing or the modprobe fails (or if the drop-in is installed on an older release otherwise). Signed-off-by: Jeff Mahoney <jeffm@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change causes the unit to load the nitro_enclaves kernel module before the service starts.
Since the modprobe@.service unit was introduced in systemd v245 and there are releases supported by this project using older versions that don't have it, we conditionally install a drop-in file to avoid the warning about the missing unit file.
We use Wants= instead of Requires= so that it's a soft dependency and will attempt to start the service even if the modprobe@ unit is missing or the modprobe fails (or if the drop-in is installed on an older release otherwise).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.