Generate PutBucketLogging

[peterrsongg]

Stacked PRs:

• ->Generate PutBucketLogging #4250
• Generate GetBucketLogging #4249

---

Description

Generate GetBucketLogging

Motivation and Context

Testing

Assembly Comparison output (non breaking)

AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.PutBucketLoggingRequest/MethodAdded: New method System.String get_ContentMD5() in Amazon.S3.Model.PutBucketLoggingRequest
AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.PutBucketLoggingRequest/MethodAdded: New method System.Void set_ContentMD5(System.String) in Amazon.S3.Model.PutBucketLoggingRequest
AssemblyComparer AWSSDK.S3.New.dll: Message Amazon.S3.Model.BucketLoggingStatus/TypeAdded: New type Amazon.S3.Model.BucketLoggingStatus

Fuzz Testing run: No backwards incompatibilities
DRY_RUN passed 7b1db732-7d93-4e80-ba86-5301f393e2ae

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project
• My change requires a change to the documentation
• I have updated the documentation accordingly
• I have read the README document
• I have added tests to cover my changes
• All new and existing tests passed

License

• I confirm that this pull request can be released under the Apache 2 license

[peterrsongg]

READ THIS

Change 1 was intentional, I'll comment why on the PR

Breaking Changes Analysis for Commit 16a3578

Summary

Analyzed the PutBucketLogging migration from custom to generated code. Found 1 CRITICAL BREAKING CHANGE.

---

BREAKING CHANGES

1. PutBucketLoggingRequest.cs - IsSetLoggingConfig() Method Logic Changed

File: sdk/src/Services/S3/Generated/Model/PutBucketLoggingRequest.cs

Issue: The IsSetLoggingConfig() method has different logic between custom and generated versions.

Old Custom Logic (deleted file):

internal bool IsSetLoggingConfig()
{
    return this.LoggingConfig != null;
}

New Generated Logic:

internal bool IsSetLoggingConfig()
{
    return this._loggingConfig != null && this._loggingConfig.IsSetTargetBucketName();
}

Breaking Impact:

• Previously, IsSetLoggingConfig() would return true if the LoggingConfig object was set, regardless of its internal state
• Now it returns true ONLY if LoggingConfig is set AND TargetBucketName is also set
• This changes the behavior for cases where LoggingConfig is instantiated but TargetBucketName is null/not set
• Code depending on the old behavior (checking if LoggingConfig object exists) will now behave differently
• This could cause marshalling logic to skip the LoggingConfig section when it should be included

---

NON-BREAKING CHANGES

1. PutBucketLoggingRequest.cs - New ContentMD5 Property Added

• New property ContentMD5 with getter, setter, and IsSetContentMD5() method was added
• This is an additive change and not breaking for existing code

2. PutBucketLoggingRequestMarshaller.cs - Logic Preserved via Custom Partial

• The custom marshalling logic for TargetPrefix (writing empty element when not set) is preserved
• Implemented in custom partial method TargetPrefixCustomMarshall in /Custom/Model/Internal/MarshallTransformations/PutBucketLoggingRequestMarshaller.cs
• Generated marshaller correctly calls this custom method
• NO BREAKING CHANGE

3. PutBucketLoggingResponseUnmarshaller.cs - Moved to Generated

• File moved from Custom to Generated folder
• Standard unmarshaller implementation with no logic changes
• NO BREAKING CHANGE

4. PutBucketLoggingResponse.cs - Moved to Generated

• Empty response class, no functional changes
• NO BREAKING CHANGE

5. BucketLoggingStatus.cs - New File

• New generated model class added
• Additive change only
• NO BREAKING CHANGE

6. String Property IsSet Methods - No Changes

• IsSetExpectedBucketOwner() uses !String.IsNullOrEmpty() in both versions (no change)
• IsSetBucketName() uses != null check in both versions (no change)
• NO BREAKING CHANGE

---

Files Analyzed: 26 out of 26

• ✅ PutBucketLoggingRequest.cs (BREAKING CHANGE FOUND)
• ✅ PutBucketLoggingRequestMarshaller.cs (Custom + Generated)
• ✅ PutBucketLoggingResponseUnmarshaller.cs
• ✅ PutBucketLoggingResponse.cs
• ✅ BucketLoggingStatus.cs
• ✅ S3BucketLoggingConfig.cs (Custom + Generated)
• ✅ RestXmlRequestMarshaller.cs/.tt (generator template changes)
• ✅ ServiceModel.cs (generator changes)
• ✅ s3.customizations.json (configuration)
• ✅ Other affected marshallers (reviewed for pattern consistency)

Total Breaking Changes Found: 1

Fuzz Test Output

Fuzz tests successfull

[peterrsongg]

This is customized to preserve this old logic here:
https://github.com/aws/aws-sdk-net/pull/4250/changes#diff-439b99ee512304f85c6927769974e9b8dbb35f61b12cfc6398afe402ef895a4fL70

[peterrsongg]

I had to add this so that I can just customize the IsSet method to control marshalling logic. But also, it's the rightr thing to do. It's also related to:
#4247

[dscpinheiro]

Was there a hand-written version of BucketLoggingStatus before? I don't see one in this PR or in https://github.com/aws/aws-sdk-net/tree/main/sdk/src/Services/S3/Custom/Model

[peterrsongg]

Nope, because this shape was flattened so there was never a handwritten version. I'll see if i can remove it.

[peterrsongg]

lots of newly generated s3 operations are making the diff hard to review. closing and will re-open a PR that is easier to review.